-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geojsontiler): add interior rings support #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for int_ring in self.feature_geometry["coordinates"][1:] | ||
] | ||
|
||
if is_roof: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those 3 lines (36-37-38) need one less tab (or else it is not applicated to multi_geom case). Also, we need to subtract height to interior rings too
if is_roof:
for coord in exterior_ring:
coord[2] -= self.height
Should be (outside of the above else
scope)
if is_roof:
for coord in exterior_ring:
coord[2] -= self.height
for interior_ring in interior_rings:
for coord in interior_ring:
coord[2] -= self.height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback. We applied the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
That PR addresses issue #64 by adding to geojsontiler support for interior rings.