Add TripStatusGroup #116
Merged
Add TripStatusGroup #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrossberndt
requested review from
skinkie,
herlitze,
pvgrumbkow and
ue71603
pvgrumbkow
previously approved these changes
Nov 11, 2020
herlitze
previously approved these changes
Nov 12, 2020
|
@skinkie Please add a review approval if you are fine with this additional change by me. Only after merging this I'll continue with the other pull requests. |
sgrossberndt
dismissed stale reviews from herlitze and pvgrumbkow
via
b9101a2
sgrossberndt
force-pushed
the
TripStatusGroup
branch
from
1cacd36 to
b9101a2
Compare
pvgrumbkow
previously approved these changes
Nov 17, 2020
herlitze
previously approved these changes
Nov 19, 2020
|
I am fine with this change, but I thought you wanted @skinkie to give his ok, since he was not part of the discussion in the meeting. |
|
Thanks, yes, wanted to and will wait for his review too :) |
|
In "planned" de correct Transmodel definition opposed to "scheduled"?
|
sgrossberndt
dismissed stale reviews from herlitze and pvgrumbkow
via
2b3fe89
sgrossberndt
force-pushed
the
TripStatusGroup
branch
from
b9101a2 to
2b3fe89
Compare
|
Fixed merge conflict, pull request content is unchanged. |
|
This patch was your proposal, @skinkie - please check whether its the correct term "unplanned" and update the branch and pull request if necessary. Let's discuss and merge it at 2020-12-03 if necessary. |
pvgrumbkow
approved these changes
Dec 3, 2020
ue71603
approved these changes
Dec 3, 2020
skinkie
approved these changes
Dec 3, 2020
|
@sgrossberndt you were faster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
TripStatusGroupconsisting of parameters which describe the current status of a trip.