Added VehicleNumber #214
Merged
Added VehicleNumber #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasAtSBB
previously approved these changes
Jul 25, 2022
skinkie
reviewed
Aug 8, 2022
Aurige
previously approved these changes
Aug 29, 2022
skinkie
reviewed
Oct 18, 2022
skinkie
reviewed
Oct 18, 2022
skinkie
previously approved these changes
Oct 18, 2022
This will however, change the intension Andreas had here. But I guess this is unavoidable as there are differences in opinion. And VehicleNumber has a different meaning and also does not exist in the way Andreas intended in Transmodel. Using TRAIN NUMBER also for non-train modes, if the service level intention is the some as fulfilled by TRAIN NUMBER seems better.
sgrossberndt
force-pushed
the
VehicleNumber-added
branch
from
0073adc to
70827e5
Compare
sgrossberndt
force-pushed
the
VehicleNumber-added
branch
from
215ff9d to
21456df
Compare
sgrossberndt
approved these changes
Oct 19, 2022
Aurige
approved these changes
Oct 20, 2022
skinkie
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After long discussion we keep TrainNumber and add Vehicle Number. Fixes #173
Documentation update still needed.