Rename TripLeg to Leg #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
requested review from
skinkie,
sgrossberndt,
herlitze,
normanoffel and
AndreasAtSBB
|
Fixes #180 |
|
will do all examples, when content is ok for group. |
|
OJP_FareSupport.xsd has a |
|
They both would align things more to what it should be. However, (a) we don’t do it everywhere and we should move the id to an attribute in that case (b) in breaks a lot of implementations (c) It does not really simplify anything in a heavy way. I agree: It is hygiene, but I am not sure, if we should do it. |
|
This is a breaking change... is this for 1.1. |
It is for 2.0. Or would you prefer not to do it? |
skinkie
previously approved these changes
Nov 24, 2022
herlitze
previously approved these changes
Dec 12, 2022
ue71603
force-pushed
the
TripLeg-to-Leg
branch
from
26f8423 to
d3a521c
Compare
AndreasAtSBB
previously approved these changes
Dec 22, 2022
trurlurl
previously approved these changes
Dec 23, 2022
skinkie
previously approved these changes
Jan 19, 2023
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
0f6cda8 to
0e21b03
Compare
# Conflicts: # docs/generated/index.html
skinkie
dismissed stale reviews from trurlurl, AndreasAtSBB, and themself
via
7f9312a
* added PlaceSortingGroup to PlaceParamStructure * Update OJP/OJP_Places.xsd * problem message for unsupported sorting method Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephan Großberndt <s.grossberndt@sidebysite.de> Co-authored-by: Stefan de Konink <stefan@konink.de> Co-authored-by: Malte Herlitze <herlitze@mentz.net>
* Necessary low level elements for User Preferences No UserPreference for the time being. New optimisation methods, walking and cycling profile and includeAlternativeOptions all for Trips
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
cf663d0 to
0e21b03
Compare
sgrossberndt
requested changes
Jan 20, 2023
skinkie
previously approved these changes
Jan 20, 2023
sgrossberndt
approved these changes
Jan 20, 2023
skinkie
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.