Switching back Place to Location #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will do all examples, when content is ok for group. |
To explain it to the others: The build currently fails as the examples have not been updated yet and thus verification of the examples with the changed xsd fails |
trurlurl
reviewed
Sep 4, 2022
trurlurl
reviewed
Sep 4, 2022
trurlurl
reviewed
Sep 4, 2022
trurlurl
requested changes
Sep 12, 2022
|
Documentation updated. |
trurlurl
previously approved these changes
Sep 12, 2022
trurlurl
previously approved these changes
Sep 19, 2022
skinkie
reviewed
Oct 18, 2022
skinkie
reviewed
Oct 18, 2022
skinkie
reviewed
Oct 18, 2022
skinkie
reviewed
Oct 18, 2022
trurlurl
previously approved these changes
Nov 24, 2022
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
Co-authored-by: Stefan de Konink <stefan@konink.de>
ue71603
force-pushed
the
Location_back_to_Place
branch
from
4c68af4 to
388bb65
Compare
ue71603
commented
Jan 27, 2023
OJP/OJP_Locations.xsd
Outdated
| @@ -125,10 +125,10 @@ | |||
| <xs:documentation>Problems related to this LOCATION result.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="Place" type="PlaceStructure"/> | |||
| <xs:element name="Location" type="PlaceStructure"/> | |||
There was a problem hiding this comment.
studidity, I guess ;-)
skinkie
approved these changes
Jan 27, 2023
trurlurl
approved these changes
Jan 28, 2023
|
@sgrossberndt if you like, you can merge. |
herlitze
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request will give us a lot of headache as it deleted two files. Perhaps we should leave the filenames as Places. What do you think?
Fixes #207