-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning BookingArrangements more closely with NeTEx #232
Conversation
will do all example, when content is ok for group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well aligned with NeTEx ... just a few comments
Documentation done - except for MultilingualString which I don't fully understand. Will MultilingualString remain in FareSupport or move to Common? Why not use InternationalText? |
@ue71603 what are you expecting from me here ? |
@Aurige If you think something needs to be dealt with within NeTEx, then I would ask you to crate an issue there. And then I can finalise things here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some xsd: instaed of xs: ... does not validate like this (in XMLSpy)
I did a few corrections, but this version is perfectly aligned with NeTEx now .... no further need on my side. |
Added documentation proposal for MultilingualString that was missing (as mentioned above). |
What we really have is:
And
@Aurige @skinkie If you think I should do it, I change to InternationalTextStructure. I guess this saves us one new element. |
Yes InternationalTextStructure looks Ok here (even if internationalisation is not harmonized across SIRI, NeTEx and OJP) |
Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
Co-authored-by: Stefan de Konink <stefan@konink.de>
0f6cda8
to
0e21b03
Compare
<xs:annotation> | ||
<xs:documentation>URL to information page.</xs:documentation> | ||
<xs:documentation>Contact fax number.</xs:documentation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need Fax? What happens or breaks if we let it away.
As i now fax really used these days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The media exists...
# Conflicts: # docs/generated/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved.
kept the Extension
Perhaps we need to outsource this to a NeTEx_include at some time. But perhaps we should sort ENUM in NeTEx first.
Fixes: #224