extensions MENTZ TimedLeg and ExchangePoint #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinkie
reviewed
Sep 21, 2022
skinkie
reviewed
Sep 21, 2022
ue71603
commented
Sep 21, 2022
|
TrackSectionExtension: EFA-XML-Format is able to provide georeferences, since EFA-XML-Format is requested of active system, the active system needs to get this information from the passives systems via OJP. This is not needed in OJP standard, since it is a workaround for existing layouts. |
ue71603
requested review from
pvgrumbkow,
herlitze,
normanoffel,
skinkie and
rcavaliere
Aurige
reviewed
Oct 3, 2022
skinkie
reviewed
Oct 11, 2022
skinkie
reviewed
Oct 11, 2022
skinkie
reviewed
Oct 11, 2022
skinkie
reviewed
Oct 26, 2022
skinkie
reviewed
Oct 26, 2022
skinkie
reviewed
Oct 26, 2022
skinkie
reviewed
Oct 26, 2022
skinkie
reviewed
Oct 26, 2022
Aurige
reviewed
Oct 27, 2022
skinkie
previously approved these changes
Nov 24, 2022
ue71603
force-pushed
the
Incorporating_EU_Spirit_LinkingAls_etc
branch
from
18bb0d2 to
e741863
Compare
Aurige
previously approved these changes
Jan 10, 2023
except the TripExtensionStructure. There a clarification from Jona is necessary.
with the discussions from LinkingAlps.
Switched SystemId to siri:ParticipantRefStructure (which is the correct thing to use) ViaSystem used for Roberto's algorithm proposal.
Co-authored-by: Stefan de Konink <stefan@konink.de>
will be done in EU spirit profile
is done with OperatorRef and Context
ue71603
force-pushed
the
Incorporating_EU_Spirit_LinkingAls_etc
branch
from
4da0a8d to
27d520f
Compare
…ls_etc # Conflicts: # docs/generated/index.html
skinkie
approved these changes
Jan 20, 2023
| @@ -364,7 +369,7 @@ | |||
| <xs:documentation>Rough estimate of the travel duration from the specified reference place to this exchange point.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="WaitDuration" type="xs:duration" default="PT0M" minOccurs="0"> | |||
| <xs:element name="WaitDuration" type="xs:duration" minOccurs="0" default="PT0M"> | |||
There was a problem hiding this comment.
I really dislike this merge frenzy without approval from several people.
This merge reverted #286 again.
Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceTrainNameExtension ==> added ServiceGroup/TrainName
ServiceTrainNumberExtension ==> not done. TrainNumber exists in TimedLeg ServiceGroup/TrainNumber
ServiceOperatorNameExtension ==> added ServiceGroup/OperatorName
TrackSectionExtension ==> not needed any more (is solved in #263)
ExchangePointWaitingTimeExtension ==> not done. WaitTime exists. Otherwise an explanation is needed, why this is not enough (ExchangePointsResultStructure/WaitTime)
ExchangePointPriorityExtension ==> added ExchangePointsResultStructure/Priority