Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebuild usage of realtime information #259

Merged
merged 19 commits into from
Jan 20, 2023
Merged

rebuild usage of realtime information #259

merged 19 commits into from
Jan 20, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Oct 26, 2022 •
edited
Loading

We now have three levels:

  • none - only timetable data
  • explanatory - realtime is used, but cancelled and disrupted journeys are still shown.
  • full - realtime information is used inf full, cancellation, blocking, consequences are taken into account

@ue71603 ue71603 added enhancement New feature or request documentation labels Oct 26, 2022
@ue71603 ue71603 added this to the v2.0 milestone Oct 26, 2022
Aurige
Aurige previously approved these changes Oct 27, 2022
View reviewed changes
sgrossberndt
sgrossberndt previously requested changes Nov 7, 2022
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
@herlitze
Copy link
Contributor

herlitze commented Nov 9, 2022

  • . When a vehicle is late and connections is not working, then the trip is not shown

Why would you not show these?

@ue71603
Copy link
Contributor Author

ue71603 commented Nov 20, 2022

  • . When a vehicle is late and connections is not working, then the trip is not shown

Why would you not show these?

changed it in the description. Was no problem in xsd

skinkie
skinkie reviewed Nov 24, 2022
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Nov 24, 2022
View reviewed changes
OJP/OJP_TripInfo.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Nov 24, 2022
View reviewed changes
OJP/OJP_StopEvents.xsd Outdated Show resolved Hide resolved
ue71603
ue71603 commented Nov 26, 2022
View reviewed changes
Copy link
Contributor Author

@ue71603 ue71603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

OJP/OJP_StopEvents.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 requested a review from skinkie November 26, 2022 13:20
herlitze
herlitze previously approved these changes Dec 12, 2022
View reviewed changes
@ue71603 ue71603 force-pushed the explanatoryrealtimedata branch from f464d2f to 0bcbb66 Compare December 17, 2022 11:02
Aurige
Aurige previously approved these changes Jan 10, 2023
View reviewed changes
trurlurl
trurlurl requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StopEventResult supports error code STOPEVENT_NOREALTIME, TripResult and MultiTrip support TRIP_REALTIMEINCOMPLETE. Shouldn't similar codes be added for TripInfoResult and RefineResult?

@ue71603
Copy link
Contributor Author

ue71603 commented Jan 16, 2023

will be adapted

@ue71603
Copy link
Contributor Author

ue71603 commented Jan 16, 2023

StopEventResult supports error code STOPEVENT_NOREALTIME, TripResult and MultiTrip support TRIP_REALTIMEINCOMPLETE. Shouldn't similar codes be added for TripInfoResult and RefineResult?

Done for TripInfo. The rest we need to do in the end.

trurlurl
trurlurl previously approved these changes Jan 16, 2023
View reviewed changes
skinkie
skinkie reviewed Jan 16, 2023
View reviewed changes
OJP/OJP_StopEvents.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jan 16, 2023
View reviewed changes
OJP/OJP_TripInfo.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jan 16, 2023
View reviewed changes
OJP/OJP_TripInfo.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jan 16, 2023
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jan 16, 2023
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jan 16, 2023
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
@skinkie
Apply suggestions from code review
edfe5ee 
Lets at least be consistent within a pull request on the word real-time.
skinkie
skinkie previously approved these changes Jan 16, 2023
View reviewed changes
skinkie
skinkie previously approved these changes Jan 17, 2023
View reviewed changes
Aurige
Aurige previously approved these changes Jan 17, 2023
View reviewed changes
trurlurl
trurlurl previously approved these changes Jan 19, 2023
View reviewed changes
@skinkie
Merge branch 'changes_for_v1.1' into explanatoryrealtimedata
5e06d74 
# Conflicts:
#	docs/generated/index.html
@skinkie skinkie dismissed stale reviews from trurlurl, Aurige, and themself via 5e06d74 January 20, 2023 10:13
AndreasAtSBB
AndreasAtSBB approved these changes Jan 20, 2023
View reviewed changes
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change: Real-time ... to Default is "full" Inluding HTML doc change.

@skinkie skinkie merged commit bf60b95 into changes_for_v1.1 Jan 20, 2023
@skinkie skinkie deleted the explanatoryrealtimedata branch January 20, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasAtSBB AndreasAtSBB AndreasAtSBB approved these changes

@skinkie skinkie skinkie approved these changes

@trurlurl trurlurl trurlurl left review comments

@herlitze herlitze herlitze left review comments

@Aurige Aurige Aurige left review comments

@normanoffel normanoffel Awaiting requested review from normanoffel

@sgrossberndt sgrossberndt Awaiting requested review from sgrossberndt

Assignees
No one assigned
Labels
doc updated enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ue71603 @herlitze @skinkie @Aurige @sgrossberndt @trurlurl @AndreasAtSBB