Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AvailabilityRequest from TRIAS #262

Merged
merged 41 commits into from
Jan 16, 2023
Merged

Conversation

trurlurl
Copy link
Contributor

@trurlurl trurlurl commented Nov 8, 2022

Please note that BookableServiceItem has the following additional values, as compared to TRIAS: boardingAssistance, alightingAssistance, onboardAssistance, unassistedMinorAssistance.

ue71603
ue71603 previously approved these changes Nov 19, 2022
@ue71603
Copy link
Contributor

ue71603 commented Nov 19, 2022

@trurlurl An example request and response would be needed at some point!

OJP/OJP_Booking.xsd Outdated Show resolved Hide resolved
@sgrossberndt
Copy link
Contributor

I took the liberty to replace this convoluted history of commits with a single one summing up the most recent state, as I was unable to rebase this cleanly on changes_for_v1.1

@sgrossberndt sgrossberndt force-pushed the availabilityrequest branch 3 times, most recently from d22bc54 to 7da0bc8 Compare November 21, 2022 15:52
OJP/OJP_Booking.xsd Outdated Show resolved Hide resolved
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You replaced my squashed commit again by yours based on the outdated changes_for_v1.1 which is not easily mergable. I will replace it again. Please update your local availabilityrequest branch before pushing again.

skinkie
skinkie previously approved these changes Nov 24, 2022
@ue71603
Copy link
Contributor

ue71603 commented Dec 1, 2022

@trurlurl looks good to me. Could you add in examples a folder "function" and add an example of a request and a response OJPAvailabiltyRequest.xml and OJPAvailabilityResponse.xml

@ue71603
Copy link
Contributor

ue71603 commented Dec 16, 2022

ErrorMessage -> Problems, Problem Enumeration

ue71603
ue71603 previously approved these changes Dec 16, 2022
OJP/OJP_Booking.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 self-assigned this Dec 16, 2022
@sgrossberndt sgrossberndt changed the title Availabilityrequest from TRIAS Add AvailabilityRequest from TRIAS Dec 16, 2022
@ue71603 ue71603 force-pushed the availabilityrequest branch from 95a7c34 to 6fa012f Compare December 22, 2022 10:37
OJP/OJP_Availability.xsd Outdated Show resolved Hide resolved
OJP/OJP_Availability.xsd Outdated Show resolved Hide resolved
OJP/OJP_Availability.xsd Show resolved Hide resolved
OJP/OJP_Availability.xsd Show resolved Hide resolved
OJP/OJP_Availability.xsd Outdated Show resolved Hide resolved
OJP/OJP_Availability.xsd Outdated Show resolved Hide resolved
OJP/OJP_Availability.xsd Outdated Show resolved Hide resolved
@ue71603 ue71603 self-requested a review December 28, 2022 16:53
@sgrossberndt sgrossberndt merged commit f1531f7 into changes_for_v1.1 Jan 16, 2023
@sgrossberndt sgrossberndt deleted the availabilityrequest branch January 16, 2023 12:06
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes, especially integration of new OJP_Availability.xsd looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc updated enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants