-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AvailabilityRequest from TRIAS #262
Conversation
@trurlurl An example request and response would be needed at some point! |
a72fac6
to
a17963b
Compare
I took the liberty to replace this convoluted history of commits with a single one summing up the most recent state, as I was unable to rebase this cleanly on changes_for_v1.1 |
d22bc54
to
7da0bc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You replaced my squashed commit again by yours based on the outdated changes_for_v1.1 which is not easily mergable. I will replace it again. Please update your local availabilityrequest branch before pushing again.
d80b82e
to
bf9e833
Compare
@trurlurl looks good to me. Could you add in examples a folder "function" and add an example of a request and a response OJPAvailabiltyRequest.xml and OJPAvailabilityResponse.xml |
ErrorMessage -> Problems, Problem Enumeration |
Removed structures in OJP_Booking that are superfluous as long as booking functionality is not intended to be implemented. I did not remove EMailAddressStructure in OJP_Utility.xsd since it fits well with similar structures (e.g., PhoneNumberType) and is likely to be useful in other contexts.
95a7c34
to
6fa012f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes, especially integration of new OJP_Availability.xsd looks fine to me.
Please note that BookableServiceItem has the following additional values, as compared to TRIAS: boardingAssistance, alightingAssistance, onboardAssistance, unassistedMinorAssistance.