Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete code in OJP_RequestSupport.xsd #294

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Obsolete code in OJP_RequestSupport.xsd #294

merged 7 commits into from
Jan 20, 2023

Conversation

trurlurl
Copy link
Contributor

The removed elements don't seem to be used anywhere in the XSD. Is it really o.k. to remove them?

@trurlurl trurlurl added question Further information is requested documentation labels Jan 11, 2023
@ue71603 ue71603 self-requested a review January 12, 2023 08:54
ue71603
ue71603 previously approved these changes Jan 12, 2023
View reviewed changes
@ue71603 ue71603 requested a review from Aurige January 12, 2023 08:55
Aurige
Aurige previously approved these changes Jan 12, 2023
View reviewed changes
skinkie
skinkie requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not want to use the SubscriptionRequest. Does the subscription request itself exist with the removal of the SubscriptionRequestContextGroup?

@sgrossberndt sgrossberndt changed the title Obsolete code in OJP_RequestSupport,xsd Obsolete code in OJP_RequestSupport.xsd Jan 16, 2023
@skinkie skinkie dismissed stale reviews from Aurige and ue71603 via 0cb1445 January 19, 2023 15:20
@ue71603
Copy link
Contributor

ue71603 commented Jan 20, 2023

Norman: Does this come from TripMonitoring?
Stephan: Guess it was.
So we can remove it now. If we do TripMonitoring we can do it.
Stefan: Concur. I want TripMonitoring

sgrossberndt
sgrossberndt previously approved these changes Jan 20, 2023
View reviewed changes
Aurige
Aurige previously approved these changes Jan 20, 2023
View reviewed changes
@skinkie skinkie dismissed stale reviews from Aurige and sgrossberndt via 60088a5 January 20, 2023 14:33
@skinkie skinkie requested a review from Aurige January 20, 2023 14:51
@sgrossberndt sgrossberndt merged commit ddf023c into changes_for_v1.1 Jan 20, 2023
@sgrossberndt sgrossberndt deleted the obsolete_code_request_support branch January 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgrossberndt sgrossberndt sgrossberndt approved these changes

@skinkie skinkie skinkie approved these changes

@herlitze herlitze Awaiting requested review from herlitze

@Aurige Aurige Awaiting requested review from Aurige

@ue71603 ue71603 Awaiting requested review from ue71603

Assignees
No one assigned
Labels
doc updated question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trurlurl @ue71603 @skinkie @Aurige @sgrossberndt