Necessary low level elements for User Preferences #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No UserPreference for the time being. New optimisation methods, walking and cycling profile and includeAlternativeOptions all for Trips
multiple OptimisationMethods with wrapper Improved docu for some points removed normal from descriptions of cycling improved description of hiking
|
superseeds: https://github.com/VDVde/OJP/pull/221/files |
ue71603
previously approved these changes
Jan 19, 2023
skinkie
previously approved these changes
Jan 19, 2023
skinkie
reviewed
Jan 19, 2023
OJP/OJP_Trips.xsd
Outdated
| <xs:element name="OptimisationMethod" type="OptimisationMethodEnumeration"/> | ||
| <xs:element name="OptimisationMethods" type="OptimisationMethodList" minOccurs="0"> | ||
| <xs:annotation> | ||
| <xs:documentation>the types of algorithm that can be used for planning a journey (fastest, least walking, etc)</xs:documentation> |
There was a problem hiding this comment.
Suggested change
| <xs:documentation>the types of algorithm that can be used for planning a journey (fastest, least walking, etc)</xs:documentation> | |
| <xs:documentation>the types of algorithm that can be used for planning a journey (fastest, least walking, etc.)</xs:documentation> |
skinkie
reviewed
Jan 19, 2023
OJP/OJP_Trips.xsd
Outdated
| <xs:sequence> | ||
| <xs:element name="OptimisationMethod" type="OptimisationMethodEnumeration" maxOccurs="unbounded"/> | ||
| </xs:sequence> | ||
| </xs:complexType> | ||
| <xs:simpleType name="OptimisationMethodEnumeration"> | ||
| <xs:annotation> | ||
| <xs:documentation>the types of algorithm that can be used for planning a journey (fastest, least walking, etc). If multiple optimisation methods are needed, then several requests should be performed in parallel.</xs:documentation> |
There was a problem hiding this comment.
Suggested change
| <xs:documentation>the types of algorithm that can be used for planning a journey (fastest, least walking, etc). If multiple optimisation methods are needed, then several requests should be performed in parallel.</xs:documentation> | |
| <xs:documentation>the types of algorithm that can be used for planning a journey (fastest, least walking, etc.). If multiple optimisation methods are needed, then several requests should be performed in parallel.</xs:documentation> |
skinkie
reviewed
Jan 19, 2023
skinkie
reviewed
Jan 19, 2023
skinkie
previously approved these changes
Jan 19, 2023
skinkie
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Trips
Documentation chapter 5.4. https://vdvde.sharepoint.com/sites/CENTC278WG3SG8OJP/Freigegebene%20Dokumente/General/Version_2.0/210713-OJP-64_e_stm-2.0_work.docx?web=1