Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First fare examples #313

Merged
merged 2 commits into from
Jan 26, 2023
Merged

First fare examples #313

merged 2 commits into from
Jan 26, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Jan 24, 2023

First fare examples.. .I needed those for our OJPFare2TOMP mapping

@ue71603 ue71603 added enhancement New feature or request documentation labels Jan 24, 2023
@ue71603 ue71603 added this to the v2.0 milestone Jan 24, 2023
@skinkie
Copy link
Contributor

skinkie commented Jan 24, 2023

If it validates, it is from my perspective ok :)

trurlurl
trurlurl approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is or should this be a more or less realistic example? FareAuthorityFilter filters for NOVA, but there are two FareResults linked to two fare authorities, NOVA and Mybuxy.

@skinkie skinkie merged commit 22179c2 into changes_for_v1.1 Jan 26, 2023
@skinkie skinkie deleted the OJPFare_Example branch March 14, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@skinkie skinkie skinkie approved these changes

@sgrossberndt sgrossberndt Awaiting requested review from sgrossberndt

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ue71603 @skinkie @trurlurl