Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherent use of ObjectIdType #316

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Coherent use of ObjectIdType #316

merged 2 commits into from
Mar 17, 2023

Conversation

trurlurl
Copy link
Contributor

Some Result, Trip, and Leg IDs had been changed from xs:NMTOKEN to ObjectIdType, see #215.
References have not been consistently adapted accordingly.

I hope it is correct that only some of the Results have an id (FareResult, StopEventResult, TripResult, and MultiPointTripResult).

@trurlurl trurlurl added bug Something isn't working documentation labels Jan 28, 2023
@trurlurl trurlurl added this to the v2.0 milestone Jan 28, 2023
@trurlurl trurlurl requested review from skinkie and ue71603 January 28, 2023 18:36
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets discuss if we would like to have an TripIdType, LegIdType, etc.

@trurlurl
Copy link
Contributor Author

I'm adding the discussion label, to discuss whether we'd like to have not simply ObjectIdType (for NeTEx objects), but TripIdType, LegIdType, etc.

Would that be wanted mainly for validation purposes? What kind of validation tool? If it were something like "Data4PT NeTEx Validator", then I'd imagine that one wanted to do more intelligent checks than just syntax-based type checking - e.g., checking whether the referenced leg id really exists somewhere. But in order specify more intelligent checks, one would probably look at each element separately and not rely on the type.

@ue71603
Copy link
Contributor

ue71603 commented Mar 10, 2023

Stefan: For validation purposes this might be a good idea.
Norman: Why do we need identity constraint?
Stefan: From code generation it would help as well.

Appreciated, but not pressing.
==> if we find somebody to do it.

skinkie
skinkie previously approved these changes Mar 13, 2023
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement in the future.

ue71603
ue71603 previously approved these changes Mar 13, 2023
@ue71603 ue71603 dismissed stale reviews from skinkie and themself via 486fb74 March 13, 2023 20:24
ue71603
ue71603 previously approved these changes Mar 13, 2023
@skinkie skinkie merged commit 0908aa2 into changes_for_v1.1 Mar 17, 2023
@sgrossberndt sgrossberndt deleted the id-simplified-2 branch March 21, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working doc updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants