-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coherent use of ObjectIdType #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets discuss if we would like to have an TripIdType, LegIdType, etc.
I'm adding the discussion label, to discuss whether we'd like to have not simply ObjectIdType (for NeTEx objects), but TripIdType, LegIdType, etc. Would that be wanted mainly for validation purposes? What kind of validation tool? If it were something like "Data4PT NeTEx Validator", then I'd imagine that one wanted to do more intelligent checks than just syntax-based type checking - e.g., checking whether the referenced leg id really exists somewhere. But in order specify more intelligent checks, one would probably look at each element separately and not rely on the type. |
Stefan: For validation purposes this might be a good idea. Appreciated, but not pressing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvement in the future.
7eb622b
to
486fb74
Compare
Some Result, Trip, and Leg IDs had been changed from xs:NMTOKEN to ObjectIdType, see #215.
References have not been consistently adapted accordingly.
I hope it is correct that only some of the Results have an id (FareResult, StopEventResult, TripResult, and MultiPointTripResult).