Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to FareResult indicating whether it was estimated #324

Merged
merged 10 commits into from
Mar 13, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Mar 2, 2023

In many cases the FareResult is only an estimate. We should be able to communicate this.

@ue71603 ue71603 added enhancement New feature or request documentation labels Mar 2, 2023
@ue71603 ue71603 added this to the v2.0 milestone Mar 2, 2023
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR wants to merge into master...?

@ue71603 ue71603 changed the base branch from master to changes_for_v1.1 March 2, 2023 23:10
@ue71603
Copy link
Contributor Author

ue71603 commented Mar 2, 2023

The PR wants to merge into master...?

now corrected.

trurlurl
trurlurl previously approved these changes Mar 3, 2023
skinkie
skinkie previously approved these changes Mar 9, 2023
OJP/OJP_Fare.xsd Outdated Show resolved Hide resolved
OJP/OJP_Fare.xsd Outdated Show resolved Hide resolved
OJP/OJP_Fare.xsd Show resolved Hide resolved
@ue71603 ue71603 dismissed stale reviews from skinkie and trurlurl via 4f844a8 March 9, 2023 13:50
@sgrossberndt
Copy link
Contributor

What does "estimated" mean, how to react to this as a receiver?

sgrossberndt
sgrossberndt previously approved these changes Mar 9, 2023
@ue71603
Copy link
Contributor Author

ue71603 commented Mar 9, 2023

@sgrossberndt Improve documentation in XSD or in specification.

The idea is: "Estimated can mean different things: The price may vary e.g. depending on age, PassangerCategory, TravelClass, EntitlementProducts). It may also mean, that the fare structure that the fare service uses is not really accurate or that other factors like time a shared car is used, may play into the price. Usually a client should then should present the price as approximate and probably lower limit of the real price."

trurlurl
trurlurl previously approved these changes Mar 9, 2023
skinkie
skinkie previously approved these changes Mar 9, 2023
@sgrossberndt sgrossberndt dismissed stale reviews from skinkie, trurlurl, and themself via 5db36b9 March 10, 2023 08:23
@sgrossberndt sgrossberndt changed the title Adding a parameter in FareResult that tells, if the result was estimated Add a parameter to FareResult indicating whether it was estimated Mar 10, 2023
@skinkie skinkie merged commit e4dd489 into changes_for_v1.1 Mar 13, 2023
@ue71603
Copy link
Contributor Author

ue71603 commented Mar 13, 2023 via email

@skinkie skinkie deleted the fareestimated2 branch March 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc updated enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants