IsAlternativeOption #326
Merged
IsAlternativeOption #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trurlurl
previously approved these changes
Mar 3, 2023
|
Shouldn't it then have a reference to the alternative? If it already has it, why explicitly mention it? |
|
It doesn't have a reference and it is not clear, why the server did it. The server may have a myriad ideas how to define the alternative. So it just mentions it, that the result may not be considered optimal by what the request asked. |
ue71603
force-pushed
the
IsAlternativeOption
branch
from
feb6c9c to
cfaaca8
Compare
trurlurl
previously approved these changes
Mar 9, 2023
|
leave it at that. |
ue71603
commented
Mar 10, 2023
skinkie
approved these changes
Mar 10, 2023
trurlurl
approved these changes
Mar 13, 2023
|
@skinkie : ready to merge.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it clear, if the trip is the result from alternative options checking.