Update to SIRI 2.1 using a copy and adapted imports #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinkie
previously approved these changes
Mar 10, 2023
|
I'd like to have only the necessary xsd sources to be in here, not siris travis integration and examples, I will come up with an updated change for this, but unfortunately this will be after my vacation on 21th of march |
skinkie
approved these changes
Mar 13, 2023
trurlurl
requested changes
Mar 13, 2023
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="AudibleSignalsAvailable" type="AccessibilityStructure" default="false"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Whether a PLACE / SITE ELEMENT is wheelchair accessible.</xsd:documentation> | ||
| <xsd:documentation>Whether a PLACE / SITE ELEMENT is wheelchair accessible. Default is 'false'.</xsd:documentation> |
There was a problem hiding this comment.
Suggested change
| <xsd:documentation>Whether a PLACE / SITE ELEMENT is wheelchair accessible. Default is 'false'.</xsd:documentation> | |
| <xsd:documentation>Whether a PLACE / SITE ELEMENT has Audible signals for the visually impaired. Default is 'false'.</xsd:documentation> |
| <xs:enumeration value="tournament"/> | ||
| <xs:enumeration value="tradeFair"/> | ||
| <xs:enumeration value="waterSportsMeeting"/> | ||
| <xs:enumeration value="wineFestival"/> | ||
| <xs:enumeration value="winterSportsMeeting"/> | ||
| <xs:enumeration value="other"/> |
There was a problem hiding this comment.
politicalDemonstration missing? Carnival and Alpabzug would be procession? :-)
AndreasAtSBB
approved these changes
Mar 14, 2023
sgrossberndt
changed the title
|
@ue71603 Does this need some update to the documentation (the documentation labe is set)? |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without copying from upstream to see, if it works....