Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardinality of ArrivalFormationAssignment #367

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

trurlurl
Copy link
Contributor

I think ArrivalFormationAssignment could occur multiple times - see discussion in #328 .

@trurlurl trurlurl added bug Something isn't working documentation labels Jun 10, 2023
@trurlurl trurlurl requested review from skinkie and ue71603 June 10, 2023 10:09
@ue71603
Copy link
Contributor

ue71603 commented Jun 12, 2023

@Aurige : Ok for me, but what do you think?

@skinkie
Copy link
Contributor

skinkie commented Jun 14, 2023

Can someone give a quick example where a formation would have a different arrival time? Would this be when splitting and joining?

@ue71603
Copy link
Contributor

ue71603 commented Jun 14, 2023

I am not sure, if I have such an example.

@trurlurl
Copy link
Contributor Author

Brainstorming kind of idea - multiple buses as a replacement of a train service ??

@ue71603
Copy link
Contributor

ue71603 commented Jun 19, 2023

Example needed for documentation. Otherwise unbounded ok.

Changed cardinality of ArrivalFormationAssignment
@ue71603 ue71603 force-pushed the arrival_formation_assignment_cardinality branch from ceb0ad7 to 6f192ea Compare June 19, 2023 21:04
@skinkie
Copy link
Contributor

skinkie commented Jun 19, 2023

I am really not fond of the unbounded here.

@ue71603
Copy link
Contributor

ue71603 commented Jun 20, 2023

I am really not fond of the unbounded here.

It is done that way in SIRI as well.

@skinkie
Copy link
Contributor

skinkie commented Jun 20, 2023

I am really not fond of the unbounded here.

It is done that way in SIRI as well.

As bug or feature? ;-)

@ue71603
Copy link
Contributor

ue71603 commented Jun 20, 2023

I will do the example and we discuss it then, if it is needed. Will talk to @haeckerbaer

@ue71603
Copy link
Contributor

ue71603 commented Jun 21, 2023

@skinkie @Aurige : I send you here the Swiss realisation guide with multiple DepartureFormationAssignments: https://www.öv-info.ch/sites/default/files/2023-04/siri_realisation-guide_pt_ch_v0.9.0.pdf

@skinkie
Copy link
Contributor

skinkie commented Jun 21, 2023

You have a long train, where each carriage is assigned to a specific sector (quay).

@trurlurl
Copy link
Contributor Author

@ue71603 You could approve it, I can't (having been the author of the PR).

@skinkie skinkie merged commit 466682b into changes_for_v1.1 Jun 21, 2023
@skinkie skinkie deleted the arrival_formation_assignment_cardinality branch June 21, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working doc updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants