Multiple BookingNotes #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trurlurl
previously approved these changes
Jun 14, 2023
|
Either one or a new element with multiple elements and Choice |
trurlurl
previously requested changes
Jun 16, 2023
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
ue71603
force-pushed
the
multiple-booking-notes1
branch
from
3c4ccfb to
c282097
Compare
|
Can we please have an example for this too? Preferably without the deprecated one. |
sgrossberndt
requested changes
Jun 20, 2023
sgrossberndt
requested changes
Jun 20, 2023
ue71603
commented
Jun 20, 2023
sgrossberndt
approved these changes
Jun 20, 2023
|
One question remaining: @Aurige mentioned these could be Notices with a NoticeAssignment. Is there any BookingNote in SIRI, NeTEx, that would justify it to create a new element? |
|
NeTEx has Notice and NoticeAssignment
|
|
This would need to be fixed in SIRI first. The bug I already put in a PR SIRI-CEN/SIRI#116 |
trurlurl
approved these changes
Jun 28, 2023
skinkie
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.