Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the LegIntermediates element to LegIntermediate (and add an example for ParallelService from ÖBB) #399

Merged
merged 20 commits into from
Sep 20, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Aug 18, 2023

working on #398 Create TR_ParallelService_OeBB.xml

Als fix LegIntermediates -> LegIntermediate

@ue71603 ue71603 added this to the v2.0 milestone Aug 18, 2023
@ue71603 ue71603 self-assigned this Aug 18, 2023
@ue71603 ue71603 marked this pull request as draft August 23, 2023 07:57
@ue71603
Copy link
Contributor Author

ue71603 commented Aug 24, 2023

An open question during review: Should the "main" service be copied to parallel service as well (to tell that NJ 490 is only NJ 490 between stations 1 to 5). Otherwise we can't say that.

Wien - NJ 490/NJ40490 -> some station - NJ 590 -> (Hamburg) - NJ50490 -> (Amsterdam)

@ue71603 ue71603 marked this pull request as ready for review August 24, 2023 08:44
@trurlurl
Copy link
Contributor

Which case should be expressed?

Case (1)
1
490 | 40490
5
590 | 50490
7
590
12

Case (2)
1
490 | 40490
5
490 | 590 | 50490
7
490 | 590
12

My interpretation might be too intuitive or simplistic, but I would expect that the Service element always applies to the complete parent which should be a dated journey. That would mean case (2), and a ParallelService 1-490-5 would not make any sense.

To represent case (1) we'd need two dated journeys, one for Austria (Service 490, ParallelService 40490) and one for Germany (Service 590, ParallelService 50490 until Nürnberg).

Perhaps I miss some complexities?

@ue71603
Copy link
Contributor Author

ue71603 commented Aug 25, 2023

What really

Which case should be expressed?

Case (1) 1 490 | 40490 5 590 | 50490 7 590 12

Case (2) 1 490 | 40490 5 490 | 590 | 50490 7 490 | 590 12

My interpretation might be too intuitive or simplistic, but I would expect that the Service element always applies to the complete parent which should be a dated journey. That would mean case (2), and a ParallelService 1-490-5 would not make any sense.

To represent case (1) we'd need two dated journeys, one for Austria (Service 490, ParallelService 40490) and one for Germany (Service 590, ParallelService 50490 until Nürnberg).

Perhaps I miss some complexities?

@trurlurl : What really happens on the rail is use case (1). However we need to provide some basic information for the Service (even when it is only going from stop 1-7. And I think departure is the important place. And really in (1) we shorten things and are not quite "true". However it is simpler. It would be always possible to model as two TimedLeg with a TransferLeg with 0 minutes and remainInVehicle. In many cases this would not be helpful. That's why I propose a duplication of the 490 1- 5 Service

@ue71603 ue71603 requested a review from Aurige August 25, 2023 11:16
@herlitze
Copy link
Contributor

I would suggest splitting the line at "some station" and have a TransferLeg with TransferMode remainInVehicle between the two Legs. The result would be:

TimedLeg
Wien -> some station - NJ 590 -> (Hamburg) - NJ50490 -> (Amsterdam)
NJ 490/NJ40490

TransferLeg
some station -> some station
with TransferMode remainInVehicle

TimedLeg
some station -> Hamburg
NJ 590

...

I know this is not the prettiest of all solutions, but I dislike the idea of having the "main" service copied to parallel service as well.

@ue71603
Copy link
Contributor Author

ue71603 commented Sep 11, 2023

@skinkie @Aurige : Having a split is ok for me as the train number really changes. What do you think? If ok for you, then I will do as @herlitze suggests.

@ue71603 ue71603 force-pushed the oebb_example_parallel_service branch from aa58c81 to e12197a Compare September 14, 2023 17:23
@ue71603
Copy link
Contributor Author

ue71603 commented Sep 18, 2023

@trurlurl @skinkie discussed with OeBB. If ok, then we can merge it.

@ue71603 ue71603 changed the title Create TR_ParallelService_OeBB.xml LegIntermediates -> LegIntermediate (and example for OeBB on ParallelService) Sep 19, 2023
@ue71603 ue71603 force-pushed the oebb_example_parallel_service branch from e12197a to c5e5599 Compare September 19, 2023 09:25
skinkie
skinkie previously approved these changes Sep 19, 2023
@sgrossberndt sgrossberndt changed the title LegIntermediates -> LegIntermediate (and example for OeBB on ParallelService) Rename the LegIntermediates element to LegIntermediate (and add an example for ParallelService from ÖBB) Sep 19, 2023
skinkie
skinkie previously approved these changes Sep 19, 2023
@sgrossberndt
Copy link
Contributor

In my opinion "Rename the LegIntermediates element to LegIntermediate" should be separated from "Add an example for ParallelService from ÖBB". Do one thing at a time.

trurlurl
trurlurl previously approved these changes Sep 19, 2023
@ue71603 ue71603 dismissed stale reviews from trurlurl and skinkie via ee6b23a September 19, 2023 16:54
@ue71603
Copy link
Contributor Author

ue71603 commented Sep 19, 2023

In my opinion "Rename the LegIntermediates element to LegIntermediate" should be separated from "Add an example for ParallelService from ÖBB". Do one thing at a time.

Will do from now on.

@sgrossberndt sgrossberndt merged commit 4e5e5c4 into changes_for_v1.1 Sep 20, 2023
1 check passed
@sgrossberndt sgrossberndt deleted the oebb_example_parallel_service branch September 20, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants