-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the LegIntermediates element to LegIntermediate (and add an example for ParallelService from ÖBB) #399
Rename the LegIntermediates element to LegIntermediate (and add an example for ParallelService from ÖBB) #399
Conversation
An open question during review: Should the "main" service be copied to parallel service as well (to tell that NJ 490 is only NJ 490 between stations 1 to 5). Otherwise we can't say that.
|
Which case should be expressed? Case (1) Case (2) My interpretation might be too intuitive or simplistic, but I would expect that the Service element always applies to the complete parent which should be a dated journey. That would mean case (2), and a ParallelService 1-490-5 would not make any sense. To represent case (1) we'd need two dated journeys, one for Austria (Service 490, ParallelService 40490) and one for Germany (Service 590, ParallelService 50490 until Nürnberg). Perhaps I miss some complexities? |
What really
@trurlurl : What really happens on the rail is use case (1). However we need to provide some basic information for the Service (even when it is only going from stop 1-7. And I think departure is the important place. And really in (1) we shorten things and are not quite "true". However it is simpler. It would be always possible to model as two TimedLeg with a TransferLeg with 0 minutes and remainInVehicle. In many cases this would not be helpful. That's why I propose a duplication of the 490 1- 5 Service |
I would suggest splitting the line at "some station" and have a TransferLeg with TransferMode remainInVehicle between the two Legs. The result would be: TimedLeg TransferLeg TimedLeg ... I know this is not the prettiest of all solutions, but I dislike the idea of having the "main" service copied to parallel service as well. |
aa58c81
to
e12197a
Compare
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
e12197a
to
c5e5599
Compare
Updated documentation
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
In my opinion "Rename the LegIntermediates element to LegIntermediate" should be separated from "Add an example for ParallelService from ÖBB". Do one thing at a time. |
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
Will do from now on. |
Update documentation comment in example
examples/functions/trip/TR_ParallelService_OeBB_right_with_remain_in_vehicle.xml
Outdated
Show resolved
Hide resolved
…ain_in_vehicle.xml
working on #398 Create TR_ParallelService_OeBB.xml
Als fix LegIntermediates -> LegIntermediate