Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Fare_example_with_park_and_ride.xml #414

Merged
merged 25 commits into from
Oct 20, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Oct 11, 2023

I face the following problems:

  1. The StopFareRequest I have no idea, what it should do This is not clear from the Request nor the Response.
    Is it really only to tell in which tariff zone it lays. I guess then we should update the definition.
    image

  2. StaticFareRequest is very weak. What are the real world applications?

image

  1. I want to add a request for the park&ride tariff. I can't do that. Even when it is in the trip as soon as implementing MODES OF OPERATION from FU 44 #379 is done, We still lack the amount of time that we will be there (or sometimes only days can be booked). Should I add this as an additional part of the TripFareRequest Structure? Or only in the MultiTripFareRequest (I prefer the second).

  2. If I need to use carTransportRail, then I should be able to not only add traveler, but also AccessMode in the params. I pay per car / truck and not by traveller.

Should I add this?

  1. When I do 4 I can also allow for cargo transport. Should we explore in this direction?

@ue71603 ue71603 added bug Something isn't working enhancement New feature or request documentation labels Oct 11, 2023
@ue71603 ue71603 added this to the v2.0 milestone Oct 11, 2023
@Aurige
Copy link
Contributor

Aurige commented Oct 12, 2023

Just as an input, we have a Parking Profile in France (http://www.normes-donnees-tc.org/wp-content/uploads/2021/10/NF_Profil-NeTEx-pour-les-ParkingsF-v1.2a.pdf ) that includes Parking Fare (see 6.2.4 and associated example). But P+R is a combined fare (Parking+PT) and a lot of different variants exist (the parking sometimes require a PT ticket, sometime a season ticket only, sometimes only a reserved area with no real control, sometime you need to buy a dedicated PT+Parking ticket ... and the offer also varies depending on the type of parking: i.e. a parking for daily commuter, or a parking for tourists to avoid having too many cars in the city, etc. ...).
So, as always for fares, that is not an easy topic.
Why not just referring fare products, expected to be defined in a NeTEx flow, in order to avoid bringing too much complexity in OJP ?

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 12, 2023

I will think some more about this. Copying from NeTEx we can't do that easily. The whole inheritance tree is different and based on SIRI. E.g. DataManagedObject and all it implies is missing.

The reason I ask, we are currently building an OJPFare pricing service for Switzerland. And park&ride is part of the things NOVA can offer. But we can't trigger it with the OJPFareRequest. We can tell there is a P&R in TripResult and we can tell, that we assume it is used. But still: Additional information like: how long it will stay there and if some kind of reduction applies is not set.

@Aurige Also: can you pls give your feedback to question 5 & 6 as well?

@Aurige
Copy link
Contributor

Aurige commented Oct 12, 2023

For 5/ I'm not sure what info you are looking for: if you put your car in the train you will have dedicated FARE PRODUCTs... Either a FARE PRODUCT combining everything (typically, you stay in your car, with your passenger, and buy a "global" ticket), either the car (or other vehicles) has a specific FARE PRODUCT (in the same or even e different train), then you buy a FP per passenger and an additional one for your vehicle.

@Aurige
Copy link
Contributor

Aurige commented Oct 12, 2023

For 6/ Cargo transport (freight) is not in the scope of NeTEx, nor in the one of WG3 ... unless you have a strong use case for it, I would refrain from opening that door !

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 16, 2023

For 6/ Cargo transport (freight) is not in the scope of NeTEx, nor in the one of WG3 ... unless you have a strong use case for it, I would refrain from opening that door !

@Aurige For rail there is one use case: There are service compartements in Swiss trains that are used for some special cargo. We would need that in the formation (and the deck plan). Was this forseen in the Transmodel deck plans?

For pooling / taxi: I think this is not covered by any other standard, is it?

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 16, 2023

For 5/ I'm not sure what info you are looking for: if you put your car in the train you will have dedicated FARE PRODUCTs... Either a FARE PRODUCT combining everything (typically, you stay in your car, with your passenger, and buy a "global" ticket), either the car (or other vehicles) has a specific FARE PRODUCT (in the same or even e different train), then you buy a FP per passenger and an additional one for your vehicle.

I am talking about OJPFareRequest. In my view there is noplace to tell the system that you are a motorcycle, car, truck for a carTransportTrail:
image

image

The SalesPackageElementRef is the only place, but I don't think it cuts the deal. Do you?

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 16, 2023

@herlitze It seems to me that P&R is not bookable with TRIAS either. Or did I miss something.

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 16, 2023

#411

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 17, 2023

@Aurige @skinkie I expanded the fare service to incorporate what I think should be done.

@ue71603 ue71603 force-pushed the fareexamplewithparkandride branch from 94e9c0e to e4b4e9b Compare October 17, 2023 13:23
OJP/OJP_Fare.xsd Show resolved Hide resolved
OJP/OJP_Fare.xsd Outdated Show resolved Hide resolved
OJP/OJP_Fare.xsd Outdated Show resolved Hide resolved
ue71603 and others added 2 commits October 19, 2023 13:13
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Copy link
Contributor

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal to make example more realistic.

ue71603 and others added 12 commits October 20, 2023 15:51
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
trurlurl
trurlurl previously approved these changes Oct 20, 2023
trurlurl
trurlurl previously approved these changes Oct 20, 2023
OJP/OJP_Fare.xsd Outdated Show resolved Hide resolved
skinkie
skinkie previously approved these changes Oct 20, 2023
@skinkie skinkie merged commit 5260845 into changes_for_v1.1 Oct 20, 2023
@skinkie skinkie deleted the fareexamplewithparkandride branch October 20, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working doc updated documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants