Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/documentation tables xcore - see PR#438 #446

Conversation

hrennau
Copy link

@hrennau hrennau commented Jun 13, 2024

Tried to address all issues from the list PR#438. A couple of items were not resolved:

  • Item 1. - I did not find the comma reported, thus could not remove anything
  • Item 7. - I reduced the repetition of local type descriptions - no duplicates among the types belonging to the same schema, and the types are no ordered. But I did not remove duplicates across different domains, as this would require an undue (as it seems to me) effort.
  • Item 8. - Concerning the formatting of cardinalities, I did not understand what is required, in particular did not understand "spaces should be removed".

@sgrossberndt sgrossberndt merged commit 946b9b5 into VDVde:feature/documentation-tables-xcore Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants