Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AllowedSystemId to InitialInputStructure #63

Merged
merged 5 commits into from
Apr 17, 2020

Conversation

pvgrumbkow
Copy link
Contributor

In a distributed environment, a location information request can refer to several regional systems. In order to allow the requesting client to restrict the meant system, a filter of system IDs can be used in InitialInputStructure.

In a distributed environment, a location information request can refer to several regional systems. In order to allow the requesting client to restrict the meant system, a filter of system IDs can be used in InitialInputStructure.
@pvgrumbkow
Copy link
Contributor Author

Solves issue #52

@pvgrumbkow pvgrumbkow added the enhancement New feature or request label Jan 31, 2020
@pvgrumbkow pvgrumbkow added this to the v1.1 milestone Jan 31, 2020
Copy link
Contributor

@herlitze herlitze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have a sequence of allowed Systems which you don't have in #62 ?

@pvgrumbkow
Copy link
Contributor Author

This pull request changes the LocationInformation request. A requestor needs to have the ability in EU-Spirit to restrict the topographic results to specified EU-Spirit systems. Therefore it must be a sequence, as the requestor must be able to specify several systems.
Pull request #62 deals with the LocationIdentification response. Each returned TopographicPlace can refer only to exactly one EU-Spirit system.

Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation about EU spirit context

herlitze
herlitze previously approved these changes Apr 17, 2020
@@ -90,6 +88,11 @@
<xs:documentation>Restricts the resulting location objects to the given geographical area.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="AllowedSystemId" type="xs:normalizedString" minOccurs="0" maxOccurs="unbounded">
<xs:annotation>
<xs:documentation>Used in distributed environments. e.g. EU-Spirit. If no sequence is given, the location information request refers to all known systems (in EU-Spirit "passive servers"). If a sequence is given, the location information request refers only to the given systems (in EU-Spirit "passive servers"). In EU-Spirit the system IDs were previously called "provider code". See https://eu-spirit.eu/</xs:documentation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove term sequence

@sgrossberndt sgrossberndt requested a review from skinkie April 17, 2020 09:36
@pvgrumbkow pvgrumbkow merged commit 2924aec into changes_for_v1.1 Apr 17, 2020
@pvgrumbkow pvgrumbkow deleted the SystemFilterForLocationInformation branch April 17, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants