Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of Location with Place #82

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Conversation

pvgrumbkow
Copy link
Contributor

According to TRANSMODEL a location is only a geographical position, while a place has a location along with other attributes. Within OJP the two terms were used inconsistently. This commit distinguishes the two terms properly. In most cases the term location was replaced by the term place. This applies to type and element names but also to annotations. This commit addresses issue #44.

According to TRANSMODEL a location is only a geographical position, while a place has a location along with other attributes. Within OJP the two terms were used inconsistently. This commit distinguishes the two terms properly. In most cases the term location was replaced by the term place. This applies to type and element names but also to annotations. This commit addresses issue #44.
@pvgrumbkow pvgrumbkow linked an issue May 19, 2020 that may be closed by this pull request
@skinkie
Copy link
Contributor

skinkie commented May 19, 2020

@pvgrumbkow is this something that is for 1.1 or for 2.0. Just asking, no judgement.

@pvgrumbkow
Copy link
Contributor Author

As far as I remember, this was planned for 1.1. This is a correction, not a functional extension.

<xs:annotation>
<xs:documentation>Location within a (moving) vehicle.</xs:documentation>
<xs:documentation>Place within a (moving) vehicle.</xs:documentation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wonder if this is the wording used in Transmodel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TRANSMODEL surely the term place is not used for what we call a TripPlace here. In lack of another term I simply used TripPlace. Perhaps we should request a term for this kind of "logical position within a vehicle" from TRANSMODEL. However, in the meantime TripLocation seems to be more wrong than TripPlace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the documentation part to something that does not suggest "seating".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check again the new description.

@pvgrumbkow pvgrumbkow requested a review from skinkie May 19, 2020 09:35
@pvgrumbkow pvgrumbkow added this to the v1.1 milestone Jun 3, 2020
Added details and explanation to the description of TripPlaceStructure.
@pvgrumbkow pvgrumbkow merged commit 75c64ff into changes_for_v1.1 Sep 9, 2020
@pvgrumbkow pvgrumbkow deleted the Location2Place branch September 9, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename LocationInformation to PlaceInformation
3 participants