-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacement of Location with Place #82
Conversation
According to TRANSMODEL a location is only a geographical position, while a place has a location along with other attributes. Within OJP the two terms were used inconsistently. This commit distinguishes the two terms properly. In most cases the term location was replaced by the term place. This applies to type and element names but also to annotations. This commit addresses issue #44.
@pvgrumbkow is this something that is for 1.1 or for 2.0. Just asking, no judgement. |
As far as I remember, this was planned for 1.1. This is a correction, not a functional extension. |
<xs:annotation> | ||
<xs:documentation>Location within a (moving) vehicle.</xs:documentation> | ||
<xs:documentation>Place within a (moving) vehicle.</xs:documentation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wonder if this is the wording used in Transmodel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TRANSMODEL surely the term place is not used for what we call a TripPlace here. In lack of another term I simply used TripPlace. Perhaps we should request a term for this kind of "logical position within a vehicle" from TRANSMODEL. However, in the meantime TripLocation seems to be more wrong than TripPlace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the documentation part to something that does not suggest "seating".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check again the new description.
Added details and explanation to the description of TripPlaceStructure.
According to TRANSMODEL a location is only a geographical position, while a place has a location along with other attributes. Within OJP the two terms were used inconsistently. This commit distinguishes the two terms properly. In most cases the term location was replaced by the term place. This applies to type and element names but also to annotations. This commit addresses issue #44.