ExcludePlacesContext and ExcludeSituationsContext #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the amount of traffic, if parts of the Context are not needed.
pvgrumbkow
requested changes
May 25, 2020
There was a problem hiding this comment.
Please change three things:
a) The switches have effect on the content included in the response. Therefore they should be part of the TripContentFilterGroup.
b) The switches in the TripContentFilterGroup are always include switches. So please define them as IncludeXXX with the default set to true.
c) Please consider also the other OJP services. Where appropriate these switches should also be included into the content filter groups of those requests.
Please change three things: a) The switches have effect on the content included in the response. Therefore they should be part of the TripContentFilterGroup. b) The switches in the TripContentFilterGroup are always include switches. So please define them as IncludeXXX with the default set to true. c) Please consider also the other OJP services. Where appropriate these switches should also be included into the content filter groups of those requests.
pvgrumbkow
requested changes
Jun 2, 2020
pvgrumbkow
approved these changes
Jun 12, 2020
herlitze
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the amount of traffic, if parts of the Context are not needed.