Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions of LineInformation, StopInformation and TripInformation St… #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ThomasKling
Copy link
Contributor

…ructure plus Number of Error Messages in DMS reduced from 10 to 0.

ThomasKling and others added 2 commits September 29, 2022 09:14
@ThomasKling
Copy link
Contributor Author

LineSymbolText redefined to InternationTextType

@ThomasKling ThomasKling closed this Nov 7, 2022
@ThomasKling ThomasKling reopened this Nov 7, 2022
@dirkweisser dirkweisser self-assigned this Dec 29, 2022
@dirkweisser
Copy link
Contributor

dirkweisser commented Jan 4, 2023

In the document which went through the review process, we deleted in the LineInformationStructure the optional LineCode of type IBIS-IP.int, introduced an optional LineSymbolCode of type IBIS-IP.int and had the LinePublicCode of this PullRequest before the new LineSymbolCode. We either had to change the document or the xsd.

@dirkweisser
Copy link
Contributor

In the document we had in the TripInformationStructure the new BlockNumber before the PatternNumber. We either had to change the document or the xsd.

</xs:annotation>
</xs:element>
<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:annotation>
<xs:documentation>Short name of the stop in the planning program and ITCS. To identify a stop on media with limited display length, e.g. older interior displays, on-board computer or ticket printer terminal.
</xs:documentation>

<xs:documentation>Information on Connections or Interchanges; not in StopSequence because of RealTimeInformation</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
<xs:annotation>
<xs:documentation>Valid fare zone at this stop point</xs:documentation>
</xs:annotation>

</xs:element>
<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:annotation>
<xs:documentation>Stop number that is used throughout the transport association (PTA) for activation of ticket printers and ticket validators. This number is not necessarily unique and is only used for stops that are used productively. This number is not required for non-productive stops (e.g. depots, parking facilities, car parks).
</xs:documentation>
</xs:annotation>

<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:annotation>
<xs:documentation>Transport company-wide internal unique number of a stopping point in the network.
</xs:documentation>
</xs:annotation>

<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:element name="StopGlobalID" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="StopGlobalID" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:element name="StopGlobalID" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:annotation>
<xs:documentation>International stop ID e.g. in Germany according to VDV432 (DHID), internationally according to NeTEx, NAPTAN.
</xs:documentation>
</xs:annotation>

</xs:annotation>
</xs:element>
<xs:element name="BlockNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>
<xs:element name="ExternalVehicleJourneyRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="ExternalVehicleJourneyRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:element name="ExternalVehicleJourneyRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:annotation>
<xs:documentation>
International trip ID e.g. in Germany according to VDV433 (DFID), internationally according to NeTEx.
</xs:documentation>
</xs:annotation>

<xs:element name="LineName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="LineShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="LineNumber" type="IBIS-IP.int" minOccurs="0"/>
<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
Copy link
Contributor

@dirkweisser dirkweisser Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
<xs:annotation>
<xs:documentation>Unique additional number for displaying symbols or special lines on and in the vehicle. This additional number is used as a supplement to the LineNumber. For example, for the display of symbols such as airport, P+R, school bus or the coding of special lines such as night buses, rail replacement services, substitute lines.
</xs:documentation>
</xs:annotation>

<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
Copy link
Contributor

@dirkweisser dirkweisser Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:annotation>
<xs:documentation> Published line identification for the passenger. For displaying the line on all media such as line network maps, timetable printouts, passenger information on the internet, on signs, the stop displays, on the exterior and interior displays of the vehicles.
</xs:documentation>
</xs:annotation>

</xs:annotation>
</xs:element>
<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:annotation>
<xs:documentation>Specification of a xml formatted text to reference an symbol for special lines. Used as alternative to the LineSymbolCode. For example for displaying an airport symbol the following string could be used: <icon type=" airport "> airport </icon>
</xs:documentation>
</xs:annotation>

</xs:element>
<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="ExternalLineRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:element name="ExternalLineRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:element name="ExternalLineRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>
<xs:annotation>
<xs:documentation>International line ID e.g. in Germany according to VDV433 DLID, internationally according to NeTEx.</xs:documentation>
</xs:annotation>

@ThomasKling
Copy link
Contributor Author

ThomasKling commented Jan 4, 2023 via email

@dirkweisser
Copy link
Contributor

ok - changed in my proposal.

What about the order? First LineCode or first LinePublicCode?

<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
<xs:annotation>
<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>
</xs:annotation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</xs:annotation>

<xs:element name="LineNumber" type="IBIS-IP.int" minOccurs="0"/>
<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
<xs:annotation>
<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>

<xs:element name="LineShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
<xs:element name="LineNumber" type="IBIS-IP.int" minOccurs="0"/>
<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
<xs:annotation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xs:annotation>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants