-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltip w/ visx customization to volcano plots #381
Conversation
|
||
.VolcanoPlotTooltip > ul > li { | ||
font-weight: normal; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: I'm just glancing back over this and can't see why this would be necessary. Perhaps I'm misremembering something. If not, I'll remove when I address feedback!
UPDATE: Seems to be necessary, one way or another, to set font-weight: normal
. Otherwise, all the content is bold. Will keep it as it is.
Here's a screencast demonstrating the styles and the logic that combines pointIDs into a single tooltip when the coordinates are shared. Note how the grey background uses black text whereas the other background colors use white text. This is to achieve an acceptable color ratio. We may want to render the background colors at the default opacity, which may be more reflective of the marker color as I'm unsure how many users will adjust the marker opacity anyway. Doing so may also necessitate changes to the text colors. Screen.Recording.2023-08-09.at.12.12.40.PM.mov |
Regarding building our code with your changes to visx, here is an idea: In your fork, set up a workflow that builds the code and commits it to a branch named something like I'm not sure if we will have to do this for all visx packages. I'll try to find an example workflow that does what I suggested. |
7d09189
to
e9f4477
Compare
NOTE: the directions for testing have been edited. We no longer need to do anything special to test this now that I've deployed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great!
Resolves #66
This PR imports our changes to the
@visx/xychart
in place ofairbnb/visx
's latest version. I did so as follows:airbnb/visx
repo, made the changes we needed to achieve the desired tooltip behavior, then opened a PR inairbnb/visx
visx
fork'sxychart-issue-979-tooltip-bug
branch to create thedeploy-visx-xychart
branch where I introduced thegh-pages
dev dependency and a simpledeploy
scriptvisx
code locally, referencing their monorepo's rootpackage.json
scriptsdeploy
script on thedeploy-visx-xychart
branch (from thevisx/xy-chart
directory, not the root of the monorepo), which created a new branch with only thevisx/xychart
package.components
package.json
to import thevisx/xychart
package from my fork, like:Testing
This work can be tested in our normal workflow, by:66-volcano-plot-tooltips
)yarn
at the root of the monorepombio-site
dev server (and skipping the cache just to be safe) via: