Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: code reviews #56

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Docs: code reviews #56

wants to merge 8 commits into from

Conversation

B0berman
Copy link

@B0berman B0berman commented Aug 23, 2024 •
edited
Loading

Adding section for code reviews

jsgalarraga
jsgalarraga reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@jsgalarraga jsgalarraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of good content here. I proposed some format changes.

Overall I also see this documentation with independent paragraphs rather than with a connected narrative, but not sure how to address it 😅

src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
jolexxa
jolexxa requested changes Sep 18, 2024
View reviewed changes
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
src/content/docs/development/code_reviews.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsgalarraga jsgalarraga jsgalarraga left review comments

@jolexxa jolexxa Awaiting requested review from jolexxa

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B0berman @jolexxa @jsgalarraga