Add support for Elasticsearch 7.x and 8.x indexing #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this cool project. I have added support for indexing pages in ES 7 & 8. I did not update the ACHE frontend search functionality, which likely also needs changes for full compatibility. But I think people will already enjoy the indexing part, since the newer ES versions >= 7.8.0 also come with docker images supporting linux/arm64/v8 OS/architecture (crucial for M1 Macbook users).
I have tested indexing with Elasticsearch version 7.17.0 and 8.2.2.
I used the following
docker-compose.yml
. Note that thexpack.security
config values are important for local development without any security.Until this pull request is accepted you may need to build your own image based on my changes and reference it in the
docker-compose.yml
instead ofvidanyu/ache
.I am open for changes, but currently am not planning on doing the frontend part as well.
Cheers