feat(ui): file explorer tab #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
irdkwmnsb
approved these changes
Feb 5, 2025
| @@ -363,5 +363,7 @@ | |||
| "CPU Platform": "CPU платформасы", | |||
| "OS": "ОС", | |||
| "SDK": "Sdk", | |||
| "ABI": "АТИ" | |||
| "ABI": "АТИ", | |||
| <Input | ||
| beforeAlign='end' | ||
| className={styles.input} | ||
| value={fileExplorerService.currentPath} |
There was a problem hiding this comment.
I don't think it's necessary to store the editing value in the store directly. useStore should be sufficient and makes sense when you consider this input as a form input
We can change the store value in onSubmit or onBlur
There was a problem hiding this comment.
I switched to using a form, but I can't make the state local because I update the editing value in a different component, for example, when I click on a folder
Comment on lines
4
to
12
| const permissionSymbols = ['x', 'w', 'r'] | ||
|
|
||
| let result = '' | ||
|
|
||
| for (let i = 0; i < permissionSymbols.length; i++) { | ||
| for (let j = 0; j < permissionSymbols.length; j++) { | ||
| result = ((value >> (i * permissionSymbols.length + j)) & 1) !== 0 ? permissionSymbols[j] + result : '-' + result | ||
| } | ||
| } |
There was a problem hiding this comment.
looks complicated
Why not
Suggested change
| const permissionSymbols = ['x', 'w', 'r'] | |
| let result = '' | |
| for (let i = 0; i < permissionSymbols.length; i++) { | |
| for (let j = 0; j < permissionSymbols.length; j++) { | |
| result = ((value >> (i * permissionSymbols.length + j)) & 1) !== 0 ? permissionSymbols[j] + result : '-' + result | |
| } | |
| } | |
| const permissionSymbols = ['x','w','r','x','w','r','x','w','r'] | |
| let result = ''.join(permissionSymbols.map((v, ind) => { | |
| if ((value >> (ind)) & 1) { | |
| return v; | |
| } else { | |
| return '-'; | |
| } | |
| }) |
| const uninstallResult = await this.deviceControlStore.uninstall(packageName) | ||
| await uninstallResult.donePromise | ||
|
|
||
| await this.deviceControlStore.uninstall(packageName) |
Comment on lines
67
to
72
| const fsRetrieveResult = await this.deviceControlStore.fsRetrieve(path) | ||
| const { content } = await fsRetrieveResult.donePromise | ||
|
|
||
| if (content) { | ||
| window.open(`${content.href}?download`, '_blank') | ||
| } |
There was a problem hiding this comment.
This seems inefficient when dealing with large files. Maybe we can stream the result?
irdkwmnsb
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.