feat(ui): display filtered rows count #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshcherbakovv
force-pushed
the
o.shcherbakov/add-filtered-rows-count/QA-16086
branch
from
d46ff5e to
ab5d918
Compare
|
DaniilSmirnov
approved these changes
Feb 6, 2025
irdkwmnsb
reviewed
Feb 7, 2025
| @@ -96,6 +96,10 @@ export const DeviceTable = observer(({ data, isSuccess, isLoading, isError }: De | |||
| table.setColumnFilters(existingColumnFilters) | |||
| }, [debouncedGlobalFilter]) | |||
|
|
|||
| useEffect(() => { | |||
| deviceTableState.setFilteredDeviceCount(table.getRowModel().rows.length) | |||
There was a problem hiding this comment.
I'm wondering if this value can be computed, and not updated with a useEffect
There was a problem hiding this comment.
I think it is impossible. The getRowModel() function returns the final model after all processing (like filtering, sorting, and any other features) has been applied. Using useEffect ensures that you capture the correct row count once all changes are reflected in the model.
irdkwmnsb
reviewed
Feb 7, 2025
| @@ -361,5 +361,6 @@ | |||
| "SD Card Mounted": "SD Card Mounted", | |||
| "CPU Platform": "CPU Platform", | |||
| "OS": "OS", | |||
| "ABI": "ABI" | |||
| "ABI": "ABI", | |||
| "Displayed devices count": "Count of displayed devices" | |||
There was a problem hiding this comment.
I think "Count of displayed devices" is too long. Maybe just "Displayed"?
irdkwmnsb
approved these changes
Feb 7, 2025
oshcherbakovv
deleted the
o.shcherbakov/add-filtered-rows-count/QA-16086
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.