-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Commit #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRありです!!!
いくつかちょっとコメントしました!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いったんcollect.tsまで見ました!
適度にコメントが多くて読みやすかったです!!
ぶっちゃけもうほとんど完成だと思います、GJ!!
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!
いくつか聞いてることだけお待ちしてます。
あと本当に気まぐれコメントなので、気に入ったものがあればぐらい!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ただのコメントです)
ここのページを直接見に来るときはおそらくブランチにしか用がないので、ブランチだけ表示するとこと、プルリクだけ表示するとこを作ると運用しやすいかもですね!
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Github Appを作り次第マージさせていただきます!!
READMEの図もありがとうございます!!わかりやすい!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
準備ができたのでマージします!
内容
Initial Commitです。
https://github.com/sevenc-nanashi/vv-preview-demo-bot を持ってきました。
関連 Issue
スクリーンショット・動画など
その他
(なし)