Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit #1

Merged
merged 23 commits into from
Nov 6, 2024
Merged

Initial Commit #1

merged 23 commits into from
Nov 6, 2024

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Nov 5, 2024

内容

Initial Commitです。
https://github.com/sevenc-nanashi/vv-preview-demo-bot を持ってきました。

関連 Issue

スクリーンショット・動画など

image

その他

(なし)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありです!!!
いくつかちょっとコメントしました!!

LICENSE Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いったんcollect.tsまで見ました!
適度にコメントが多くて読みやすかったです!!

ぶっちゃけもうほとんど完成だと思います、GJ!!

package.json Outdated Show resolved Hide resolved
.github/workflows/update_pages.yml Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

いくつか聞いてることだけお待ちしてます。
あと本当に気まぐれコメントなので、気に入ったものがあればぐらい!

README.md Outdated Show resolved Hide resolved
scripts/collect.ts Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
scripts/collect.ts Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ただのコメントです)

ここのページを直接見に来るときはおそらくブランチにしか用がないので、ブランチだけ表示するとこと、プルリクだけ表示するとこを作ると運用しやすいかもですね!

src/App.vue Outdated Show resolved Hide resolved
sevenc-nanashi and others added 2 commits November 6, 2024 00:38
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
README.md Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Github Appを作り次第マージさせていただきます!!

READMEの図もありがとうございます!!わかりやすい!!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

準備ができたのでマージします!

@Hiroshiba Hiroshiba merged commit 40189c7 into VOICEVOX:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants