EditorHome.vueとpreload.tsで使われているfs、pathモジュールをメインに移してnodeitegrationをfalseに #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chModeItemClicked
Hiroshiba
reviewed
Dec 14, 2022
Hiroshiba
reviewed
Dec 14, 2022
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
レンダラーでfs、pathが使われている箇所を単純にメイン側で実行するように置き換えただけですが、非同期になるため、getterで実装されていた
PROJECT_NAMEをGET_PROJECT_NAME actionに置き換えています。それに伴ってタイトルテキスト生成周りが若干野暮ったくなりました。
sandboxをtrueにしても特に問題無い感じでしたがとりあえずfalseにしてあります。
関連 Issue
close #1017
スクリーンショット・動画など
その他