Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script setup：vueとquasarを更新 #1084

Merged
merged 2 commits into from
Jan 4, 2023
Merged

script setup：vueとquasarを更新 #1084

merged 2 commits into from
Jan 4, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

script setupにするため、vueとquasarを更新します。
vueはdefineProps周りのエラー関連、quasarはscript setup対応のためにアップデートしています。

関連 Issue

スクリーンショット・動画など

（なし）

その他

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner January 3, 2023 01:27
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team January 3, 2023 01:27
Hiroshiba
Hiroshiba approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

quasarが更新されたのでUIをざっと確認してみましたが、壊れているところは見当たりませんでした！

以前にquasarのバージョン上げで壊れてた箇所があったのですが、↓の流れの通りちゃんと解消できていそうでした！

@Hiroshiba
Copy link
Member

@MT224244 さん or @y-chan さん
ご確認頂けると心強いです！！

@Hiroshiba Hiroshiba requested review from y-chan and MT224244 January 3, 2023 05:08
y-chan
y-chan approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

@Hiroshiba Hiroshiba removed the request for review from MT224244 January 4, 2023 11:17
@Hiroshiba
Copy link
Member

マージします！！

@Hiroshiba Hiroshiba merged commit 236acf5 into VOICEVOX:main Jan 4, 2023
@y-chan y-chan mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenc-nanashi @Hiroshiba @y-chan