script setup：マークダウン系のコンポーネントを移行 #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jan 6, 2023
Comment on lines
+75
to
+78
| const emit = | ||
| defineEmits<{ | ||
| (e: "update:modelValue", value: boolean): void; | ||
| }>(); |
|
|
||
| setup(props, { emit }) { |
There was a problem hiding this comment.
あれ、そういえば以前はemit書かれてないですね。書かなくても大丈夫だったのかな。
|
あ、もしよかったら @k-chop さんも見てみて頂けると心強いです！！ |
|
emit、使い方から推論してより詳しい型書いて頂いてるんですね、ありがとうございます 🙏 |
k-chop
approved these changes
Jan 7, 2023
|
PR・レビューありがとうございます！マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
マークダウン系のコンポーネントをscript setupに移行します。
どのファイルを変更したかはFiles Changedを参照して下さい。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）