script setup：Audio系を移行 #1101
Merged
script setup：Audio系を移行 #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
Hiroshiba
reviewed
Jan 11, 2023
Hiroshiba
reviewed
Jan 11, 2023
Hiroshiba
reviewed
Jan 11, 2023
Hiroshiba
reviewed
Jan 11, 2023
|
修正できたと思います。 |
Hiroshiba
reviewed
Jan 12, 2023
src/components/AudioAccent.vue
Outdated
Comment on lines
67
to
81
| const props = withDefaults( | ||
| defineProps<{ | ||
| accentPhrase: AccentPhrase; | ||
| accentPhraseIndex: number; | ||
| uiLocked: boolean; | ||
| shiftKeyFlag: boolean; | ||
| shiftKeyFlag?: boolean; | ||
| onChangeAccent: ( | ||
| accentPhraseIndex: number, | ||
| accent: number | ||
| ) => Promise<void>; | ||
| }>(); | ||
| }>(), | ||
| { | ||
| shiftKeyFlag: false, | ||
| } | ||
| ); |
There was a problem hiding this comment.
おーーーこんな感じの見た目になるんですね。悪くないですね！！
Hiroshiba
approved these changes
Jan 12, 2023
k-chop
approved these changes
Jan 14, 2023
|
（動作確認して問題なく動いていたのと、コード側の問題ではなさそうだし直す必要はないと思いますが情報共有として） volarかvueの型定義の問題？バグ？なのかは分かりませんが、
|
|
謎ですね。。そのうちVueかVolarのバージョンを上げると直るかも。 @sevenc-nanashi すみません、コンフリクト出ちゃったので修正お願いできると 🙇♂️ |
|
マージしました…っていうかapplyPreset: trueを増やしたところ、未使用ですね |
|
ほんとに申し訳ありません･･･ 次はすぐマージさせていただこうと思います 🙇♂️ |
|
conflict解消しましたー。 |
thiramisu
added a commit
to thiramisu/voicevox
that referenced
this pull request
Jul 6, 2023
VOICEVOX#1101 で focusTextField()が上のほうに移動されたために意味不明になっていたコメントを更新
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Audio系のコンポーネントを移行します。
関連 Issue
スクリーンショット・動画など
（なし）
その他
（なし）