Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: 未保存時のダイアログを改善 #1238

Merged
merged 1 commit into from
Feb 28, 2023
Merged

ENH: 未保存時のダイアログを改善 #1238

merged 1 commit into from
Feb 28, 2023

Conversation

sabonerune
Copy link
Contributor

内容

Twitterでこのような要望をみかけたためある程度改善してみました。
https://twitter.com/HanoMotoCraft/status/1629101061415006209

  • デフォルトのカーソルをキャンセルに変更。
  • 保存ボタンを追加して保存が成功した場合はそのまま終了、キャンセルした場合は警告をキャンセルした場合と同じ状態へ。

(Windowsのメモ帳と大体同じ動作?)

スクリーンショット・動画など

現在のUI
変更後のUI

その他

Windows以外の環境での表示は確認できていません。

@sabonerune sabonerune requested a review from a team as a code owner February 27, 2023 22:28
@sabonerune sabonerune requested review from y-chan and removed request for a team February 27, 2023 22:28
y-chan
y-chan approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！
私も若干気になっていたので、これで使いやすくなると思います...!

Hiroshiba
Hiroshiba approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

ほんとに助かります！！
マージされたとツイート主さんにご連絡しても良いかもですね！

@Hiroshiba Hiroshiba merged commit 6db58f3 into VOICEVOX:main Feb 28, 2023
@sabonerune sabonerune deleted the feature/better-check-edited-and-not-save branch February 28, 2023 14:22
@Hiroshiba
Copy link
Member

あ！
同じような感じで破棄と保存を問う箇所がまだ２つくらいありました。
（「変更を破棄しても」でコード内検索すると見つかった）

んー　ちょっとPR作ってみます！

@sabonerune
Copy link
Contributor Author

失念していました。
お願いします。

@Hiroshiba Hiroshiba mentioned this pull request Feb 28, 2023
Merged
@y-chan y-chan mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabonerune @Hiroshiba @y-chan