Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: ESLintのany警告を無効化 #1285

Merged
merged 1 commit into from
Apr 11, 2023
Merged

CI: ESLintのany警告を無効化 #1285

merged 1 commit into from
Apr 11, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通り。毎回出て警告が増えたことに気がつきにくかったので無効化しました。FIXMEも置いてありますが、諦めてもよさそう？

関連 Issue

（なし）

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner April 10, 2023 06:36
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team April 10, 2023 06:36
Hiroshiba
Hiroshiba approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

（proxyのとこは @yamachu さんにも共有）

y-chan
y-chan approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
まあ直したいけど仕方ないなーって感じですね...

@Hiroshiba Hiroshiba merged commit e774a4e into VOICEVOX:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevenc-nanashi @Hiroshiba @y-chan