Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

設定画面に “非表示にしたヒントを全て再表示する” ボタンを追加 #1318

Merged
merged 6 commits into from
May 24, 2023

Conversation

wappon28dev
Copy link
Contributor

内容

現状,

  • マウスホイールでの微調整ができること
  • 代替ポート情報のトースト通知をする

などの表示済みのヒントを再表示する方法が, 設定ファイルをいじる以外ないので, 再表示するボタンを設定画面に追加します.

関連 Issue

ref: #1317 (comment)

スクリーンショット・動画など

image

その他

@wappon28dev wappon28dev requested a review from a team as a code owner May 19, 2023 15:41
@wappon28dev wappon28dev requested review from Hiroshiba and removed request for a team May 19, 2023 15:41
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

src/components/SettingDialog.vue Outdated Show resolved Hide resolved
src/components/SettingDialog.vue Outdated Show resolved Hide resolved
src/components/SettingDialog.vue Show resolved Hide resolved
@wappon28dev
Copy link
Contributor Author

レビュー反映しましたー. また気になるところがあれば…!

@wappon28dev wappon28dev changed the title 設定画面に “表示済みのヒントを全て再表示する” ボタンを追加 設定画面に “非表示にしたヒントを全て再表示する” ボタンを追加 May 22, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

丁寧なPR進行とても助かります、ありがとうございました!!

@Hiroshiba
Copy link
Member

多分問題ないと思うのでマージします!

@Hiroshiba Hiroshiba merged commit 064c2d5 into VOICEVOX:main May 24, 2023
@wappon28dev wappon28dev deleted the add/reset-confirmed-tips branch May 24, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants