-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
設定画面に “非表示にしたヒントを全て再表示する” ボタンを追加 #1318
Merged
Hiroshiba
merged 6 commits into
VOICEVOX:main
from
wappon28dev:add/reset-confirmed-tips
May 24, 2023
Merged
設定画面に “非表示にしたヒントを全て再表示する” ボタンを追加 #1318
Hiroshiba
merged 6 commits into
VOICEVOX:main
from
wappon28dev:add/reset-confirmed-tips
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wappon28dev
commented
May 19, 2023
wappon28dev
commented
May 20, 2023
Hiroshiba
reviewed
May 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!
レビュー反映しましたー. また気になるところがあれば…! |
wappon28dev
changed the title
設定画面に “表示済みのヒントを全て再表示する” ボタンを追加
設定画面に “非表示にしたヒントを全て再表示する” ボタンを追加
May 22, 2023
Hiroshiba
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
丁寧なPR進行とても助かります、ありがとうございました!!
多分問題ないと思うのでマージします! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
現状,
などの表示済みのヒントを再表示する方法が, 設定ファイルをいじる以外ないので, 再表示するボタンを設定画面に追加します.
関連 Issue
ref: #1317 (comment)
スクリーンショット・動画など
その他