Fix: マウスホイールでパラメータ調整ができないバグ(#1437)を修正 #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
自分の見立てではpreviewSliderHelper.tsには直接値を変更する機能はなく、スクロール時はonChange(value)を呼び出すだけのように見えました。 |
thiramisu
changed the title
y-chan
approved these changes
Aug 1, 2023
|
あ、発生原因を書き忘れていたので一応書き残しておきます。 あとJSDocをミスっていることに気が付いてしまったので、そのコメントアウトだけ修正しました。 |
Hiroshiba
approved these changes
Aug 3, 2023
Hiroshiba
reviewed
Aug 3, 2023
| @@ -65,7 +80,7 @@ export const previewSliderHelper = (props: Props): PreviewSliderHelper => { | |||
| // Reactive references of each props | |||
| const modelValue = computed(props.modelValue); | |||
| const min = computed(() => (props.min && props.min()) ?? 0); | |||
| const max = computed(() => (props.max && props.max()) ?? 100); | |||
There was a problem hiding this comment.
ただのメモですが、元々デフォルトパラメーターが100に設定されてたのは、quasarのデフォルト値がそうだったからだったりします。
There was a problem hiding this comment.
そうだったんですね！それならまあどちらでも良かったかもです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#1437 の修正PRです。
Vue力不足により、再生と保存にしっかり反映されること以外大丈夫なのかよく分かっていません…。
唯一機能していたモーフィングの実装を真似したのですが、ダメそうだったらcloseしていただいて他の方にお任せしようかと…！
関連 Issue
close #1437
スクリーンショット・動画など
_VOICEVOX.-.Ver.999.999.999.2023-07-31.07-30-02.mp4
その他