Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アップデート通知のe2eテスト #1716

Conversation

Hiroshiba
Copy link
Member

内容

アップデート通知のe2eテストを足しました。
利用規約とかに同意する前にアプデ通知が表示されるバグがあったのでついでに直しました。

スクリーンショット・動画など

video.webm

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 16, 2024 23:03
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 16, 2024 23:03
Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もしよかったらどなたか見ていただけると・・・!!

Comment on lines +8 to +15
// undefinedかnullでないことを保証する
export function assertNonNullable<T>(
value: T
): asserts value is NonNullable<T> {
if (value == undefined) {
throw new Error("Value is null or undefined");
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

型ガード。どんどん使っていきたいけど、このPRに必要だったかというと・・・。

ブラウザ版を起動している状態で以下のコマンドを実行してください
**ブラウザ版を起動している状態で**以下のコマンドを実行してください
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

条件に気づきづらい気がしたので

@Hiroshiba
Copy link
Member Author

0.15に必要なのでマージします!

@Hiroshiba Hiroshiba merged commit 8f1b395 into VOICEVOX:main Jan 17, 2024
7 checks passed
@Hiroshiba Hiroshiba deleted the アップデート通知ダイアログをテストする branch January 17, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant