Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: CIでのエンジンポートを変更 #1726

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Jan 19, 2024

内容

CIでのエンジンポートを50021からランダムに変更します。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner January 19, 2024 15:10
@sevenc-nanashi sevenc-nanashi requested review from y-chan and removed request for a team January 19, 2024 15:10
@Hiroshiba Hiroshiba requested review from Hiroshiba and removed request for y-chan January 19, 2024 16:31
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、予期せぬ出来事を防ぐために、空いてるポートをシェルスクリプトで見つけるのはどうでしょう。
pythonであればワンライナーでこう書けるっぽかったです。

python -c "import socket; s=socket.socket(); s.bind(('', 0)); print(s.getsockname()[1]); s.close()"

@sevenc-nanashi
Copy link
Member Author

nodeで似たようなことができたのでそうしました。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

nodeにあるのは盲点でした。こっちのが良いですね。

.github/workflows/test.yml Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 09f6335 into VOICEVOX:main Jan 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants