Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Menu系のコンポーネントをまとめ、型を別ファイルに分ける #1824

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@
<script setup lang="ts">
import { computed, onMounted, onUnmounted, ref } from "vue";
import { QMenu } from "quasar";
import MenuItem from "@/components/MenuItem.vue";
import {
MenuItemButton,
MenuItemSeparator,
} from "@/components/BaseMenuBar.vue";
import MenuItem from "./MenuItem.vue";
import { MenuItemButton, MenuItemSeparator } from "./type";
import { useStore } from "@/store";

defineProps<{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,40 +28,13 @@

<script setup lang="ts">
import { ref, computed, watch } from "vue";
import MenuButton from "./MenuButton.vue";
import { MenuItemData, MenuItemRoot } from "../type";
import MenuButton from "../MenuButton.vue";
import TitleBarButtons from "./TitleBarButtons.vue";
import TitleBarEditorSwitcher from "./TitleBarEditorSwitcher.vue";
import { useStore } from "@/store";
import { base64ImageToUri } from "@/helpers/imageHelper";

export type MenuItemBase<T extends string> = {
type: T;
label?: string;
};

export type MenuItemSeparator = MenuItemBase<"separator">;

export type MenuItemRoot = MenuItemBase<"root"> & {
onClick?: () => void;
subMenu: MenuItemData[];
icon?: string;
disabled?: boolean;
disableWhenUiLocked: boolean;
disablreloadingLocked?: boolean;
};

export type MenuItemButton = MenuItemBase<"button"> & {
onClick: () => void;
icon?: string;
disabled?: boolean;
disableWhenUiLocked: boolean;
disablreloadingLocked?: boolean;
};

export type MenuItemData = MenuItemSeparator | MenuItemRoot | MenuItemButton;

export type MenuItemType = MenuItemData["type"];

const props =
defineProps<{
/** 「ファイル」メニューのサブメニュー */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@

<script setup lang="ts">
import { computed } from "vue";
import MinMaxCloseButtons from "./MinMaxCloseButtons.vue";
import { useStore } from "@/store";
import MinMaxCloseButtons from "@/components/MinMaxCloseButtons.vue";

const store = useStore();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
<script setup lang="ts">
import { computed, ref, watch } from "vue";
import { debounce } from "quasar";
import MenuItem from "@/components/MenuItem.vue";
import { MenuItemData } from "@/components/BaseMenuBar.vue";
import MenuItem from "./MenuItem.vue";
import { MenuItemData } from "./type";
import { useStore } from "@/store";

const props = withDefaults(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

<script setup lang="ts">
import { ref, computed, watch } from "vue";
import type { MenuItemData } from "@/components/BaseMenuBar.vue";
import { MenuItemData } from "./type";
import { useStore } from "@/store";
import { hotkeyActionSchema } from "@/type/preload";
const props = withDefaults(
Expand Down
27 changes: 27 additions & 0 deletions src/components/Menu/type.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
export type MenuItemBase<T extends string> = {
type: T;
label?: string;
};

export type MenuItemSeparator = MenuItemBase<"separator">;

export type MenuItemRoot = MenuItemBase<"root"> & {
onClick?: () => void;
subMenu: MenuItemData[];
icon?: string;
disabled?: boolean;
disableWhenUiLocked: boolean;
disablreloadingLocked?: boolean;
};

export type MenuItemButton = MenuItemBase<"button"> & {
onClick: () => void;
icon?: string;
disabled?: boolean;
disableWhenUiLocked: boolean;
disablreloadingLocked?: boolean;
};

export type MenuItemData = MenuItemSeparator | MenuItemRoot | MenuItemButton;

export type MenuItemType = MenuItemData["type"];
3 changes: 2 additions & 1 deletion src/components/Sing/MenuBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@

<script setup lang="ts">
import { computed } from "vue";
import { MenuItemData } from "@/components/Menu/type";
import { useStore } from "@/store";
import { HotkeyActionType, HotkeyReturnType } from "@/type/preload";
import { setHotkeyFunctions } from "@/store/setting";
import BaseMenuBar, { MenuItemData } from "@/components/BaseMenuBar.vue";
import BaseMenuBar from "@/components/Menu/MenuBar/BaseMenuBar.vue";

const store = useStore();
const uiLocked = computed(() => store.getters.UI_LOCKED);
Expand Down
4 changes: 2 additions & 2 deletions src/components/Sing/SequencerNote.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ import {
tickToBaseX,
noteNumberToBaseY,
} from "@/sing/viewHelper";
import ContextMenu from "@/components/ContextMenu.vue";
import { MenuItemButton } from "@/components/BaseMenuBar.vue";
import ContextMenu from "@/components/Menu/ContextMenu.vue";
import { MenuItemButton } from "@/components/Menu/type";

type NoteState = "NORMAL" | "SELECTED" | "OVERLAPPING";

Expand Down
4 changes: 2 additions & 2 deletions src/components/Talk/AccentPhrase.vue
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@
import { computed, ref } from "vue";
import AudioAccent from "./AudioAccent.vue";
import AudioParameter from "./AudioParameter.vue";
import { MenuItemButton } from "@/components/BaseMenuBar.vue";
import ContextMenu from "@/components/ContextMenu.vue";
import { MenuItemButton } from "@/components/Menu/type";
import ContextMenu from "@/components/Menu/ContextMenu.vue";
import { useStore } from "@/store";
import { AudioKey, MoraDataType } from "@/type/preload";
import { Mora } from "@/openapi/models/Mora";
Expand Down
7 changes: 2 additions & 5 deletions src/components/Talk/AudioCell.vue
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,8 @@
import { computed, watch, ref, nextTick } from "vue";
import { QInput } from "quasar";
import CharacterButton from "@/components/CharacterButton.vue";
import {
MenuItemButton,
MenuItemSeparator,
} from "@/components/BaseMenuBar.vue";
import ContextMenu from "@/components/ContextMenu.vue";
import { MenuItemButton, MenuItemSeparator } from "@/components/Menu/type";
import ContextMenu from "@/components/Menu/ContextMenu.vue";
import { useStore } from "@/store";
import { AudioKey, SplitTextWhenPasteType, Voice } from "@/type/preload";
import { SelectionHelperForQInput } from "@/helpers/SelectionHelperForQInput";
Expand Down
3 changes: 2 additions & 1 deletion src/components/Talk/MenuBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@

<script setup lang="ts">
import { computed, ref, watch } from "vue";
import { MenuItemData } from "@/components/Menu/type";
import {
generateAndConnectAndSaveAudioWithDialog,
multiGenerateAndSaveAudioWithDialog,
generateAndSaveOneAudioWithDialog,
connectAndExportTextWithDialog,
} from "@/components/Dialog/Dialog";
import BaseMenuBar, { MenuItemData } from "@/components/BaseMenuBar.vue";
import BaseMenuBar from "@/components/Menu/MenuBar/BaseMenuBar.vue";

import { useStore } from "@/store";
import { HotkeyActionType, HotkeyReturnType } from "@/type/preload";
Expand Down
Loading