Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IPCメッセージのsenderを確認する #2151

Merged

Conversation

sabonerune
Copy link
Contributor

内容

Electronのベストプラクティスに基づきセキュリティを強化します。

17. すべての IPC メッセージの sender を確認する

その他

開発時は開発サーバーから、製品版ではappプロトコルからであることを確認して意図しないフレームからのIPCを防ぎます。

@sabonerune sabonerune requested a review from a team as a code owner July 1, 2024 14:44
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team July 1, 2024 14:44
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

気づいてくださってありがとうございます!!
こんな感じの変更はいつでも受け付けているので気軽に送ったりissue作っていただけたりしていただけると心強いです!!

src/backend/electron/ipc.ts Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 4ea08d1 into VOICEVOX:main Jul 1, 2024
9 checks passed
@sabonerune sabonerune deleted the feat/validate-ipc-message-sender branch July 2, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants