feat: appプロトコルでfetch可能なディレクトリを制限する #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabonerune
commented
Jul 2, 2024
src/backend/electron/main.ts
Outdated
Comment on lines
436
to
440
| const isUnsafe = | ||
| path.isAbsolute(relativePath) || | ||
| relativePath.startsWith(`..${path.sep}`) || | ||
| relativePath === ".." || | ||
| relativePath === ""; |
There was a problem hiding this comment.
voicevox/src/backend/electron/main.ts
Lines 652 to 656 in 4ea08d1
ここと共通化できそうな気がしたのですが
relativePath === ""をどうするかという問題と「あるパスがあるパスの親ディレクトリであるか」を判定する関数を作ると考慮漏れやミスが起きそうでとりあえずしていません。
There was a problem hiding this comment.
ですね！ 役割が違ってくる思うので、共通化は避けるべきだと思います！
Hiroshiba
reviewed
Jul 3, 2024
Hiroshiba
reviewed
Jul 4, 2024
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Electronのベストプラクティスに基づきセキュリティを強化します。
18. Avoid usage of the
file://protocol and prefer usage of custom protocolsref: https://www.electronjs.org/ja/docs/latest/api/protocol#protocolhandlescheme-handler
その他
app://プロトコルのファイルパスを制限して意図しないファイルの読み込みを防ぎます。