feat: ウインドウの作成とナビゲーションを無効化する #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Electronのベストプラクティスに基づきセキュリティを強化します。
13. ナビゲーションを無効化か制限
14. 新規ウインドウの作成を無効化か制限
15. 信用されないコンテンツで shell.openExternal を使用しない
(部分的)
その他
ナビゲーションと新規ウインドウ作成は現状することはないはずなので無効化します。
shell.openExternalはhttp:かhttps:の場合に実行します。これは
mailto:などを拒否してしまう一方で危険なURLでも問答無用で開いてしまいます。