[project-sequencer-statemachine] MoveNoteStateを追加 #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
sigprogramming
commented
Dec 12, 2024
Comment on lines
-169
to
-170
| context.storeActions.deselectAllNotes(); | ||
|
|
There was a problem hiding this comment.
プレビュー開始時のノートの選択・選択解除はIdleStateで行うようにしました。
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
12 tasks
Hiroshiba
reviewed
Dec 15, 2024
Hiroshiba
approved these changes
Dec 19, 2024
Comment on lines
+404
to
+413
| for (const note of editedNotes.values()) { | ||
| if (note.noteNumber < 0 || note.noteNumber >= keyInfos.length) { | ||
| // MIDIキー範囲外へはドラッグしない | ||
| return; | ||
| } | ||
| if (note.position < 0) { | ||
| // 左端より前はドラッグしない | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
（ただのコメントです）
ここ、可能ならドラッグ処理を打ち切るのではなく、範囲外に行かない範囲でドラッグ処理を実行してあげるとより優しいかもですね！
|
テストが落ちてしまっていますが↓を取り込んだmainブランチを取り込めば解決すると思います！ |
Hiroshiba
merged commit a4c4696
into
VOICEVOX:project-sequencer-statemachine
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下を行います。
MoveNoteStateを追加関連 Issue
その他