モデルファイル同梱でのdll名指定をなくす #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
現在のWindowsでのファイル埋め込みでは、dllファイルからファイルを得るのに必要なhandlerを取得するために、dllファイル名(core)をコード中で指定しています。しかし、これは今後のdll使用の中で、ファイル名を変更する際に支障をきたします
そこで、handlerを取得する関数を
GetModuleHandlerからGetModuleHandlerExに変更し、ファイル読み込み関数自身のアドレスからhandlerを取得させることでdll名の指定を不要にします参考
https://stackoverflow.com/questions/557081/how-do-i-get-the-hmodule-for-the-currently-executing-code
https://gist.github.com/davidruhmann/8008844