TTSライブラリにおけるwav生成処理の修正 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PickledChair
commented
Mar 26, 2022
| @@ -457,6 +442,7 @@ std::vector<float> SynthesisEngine::synthesis(AudioQueryModel query, int64_t *sp | |||
| } | |||
| phoneme_length_list.push_back(post_phoneme_length); | |||
| f0_list.push_back(0.0); | |||
| voiced.push_back(false); | |||
There was a problem hiding this comment.
この部分の修正は今回のバグ修正とは関係がないですが、f0_list と voiced の要素数が不一致になっているのを発見したので、ついでに修正しました。
y-chan
approved these changes
Mar 27, 2022
y-chan
pushed a commit
to SHAREVOX/sharevox_core
that referenced
this pull request
Sep 1, 2022
* wavバイナリの生成処理を修正 * f0_listとvoicedの要素数を揃える
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
wavバイナリの生成時に正しくバイナリサイズを計算できていないと思われる箇所があったので修正しました。
wavバイナリを一通り生成した後に、ファイルサイズや波形データのサイズを再計算する処理がありましたが、そこにもバグがありました。修正することも考えたのですが不要な処理のようにも思えたので削除しました。もしこの処理が必要な理由があった場合は、再計算の処理を再挿入してからバグ修正したいと思います。