Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releaseのzipをターゲットごとに分割する #111

Merged
merged 7 commits into from
Apr 7, 2022

Conversation

Oyaki122
Copy link
Member

内容

#106 のzip分割を実装します
#99 (review) に倣い、動的ライブラリファイルの名称は現状と同様にリネームしています

関連 Issue

ref #106

@Hiroshiba
Copy link
Member

プルリクありがとうございます!!
ちなみにReleaseの試作とかあったりされますか?👀
ファイル名などがどんな感じになるのかを見てみたいと思った次第です!(こちらでしょうか)

@Oyaki122
Copy link
Member Author

Oyaki122 commented Apr 1, 2022

そのリンクです

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

エンジン側のビルドに詳しい方からも一応レビュー頂けると嬉しいです!!
@aoirint さん、 @y-chan さん、 @PickledChair さんあたり?)

.github/workflows/build.yml Outdated Show resolved Hide resolved
@Oyaki122 Oyaki122 mentioned this pull request Apr 5, 2022
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PickledChair PickledChair merged commit 802ef91 into VOICEVOX:main Apr 7, 2022
@Oyaki122 Oyaki122 deleted the separate_release branch April 8, 2022 14:48
y-chan pushed a commit to SHAREVOX/sharevox_core that referenced this pull request Sep 1, 2022
* とりあえず実装

* デバッグ用に条件を解除

* fix

* zip周りを変更

* デバッグ用のif外しを元に戻す

* cd releaseが残っていたので削除

* cd -に変更
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants