Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yukarin_s_forwardで負の値を取らないようにする #47

Merged
merged 11 commits into from
Dec 8, 2021

Conversation

Oyaki122
Copy link
Member

@Oyaki122 Oyaki122 commented Dec 7, 2021

内容

#32 の実装です

混ぜてしまって申し訳ありませんが、.vscodeフォルダ関係でgitignoreを更新しています

関連 Issue

close #32

その他

こういう意図であっているんでしょうか…?

@Oyaki122 Oyaki122 changed the title yukarin_s_forwardで負の値を取らないようにする #32 yukarin_s_forwardで負の値を取らないようにする Dec 7, 2021
@Oyaki122 Oyaki122 marked this pull request as ready for review December 7, 2021 15:30
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@Yosshi999 Yosshi999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっと気になった点をコメントしました。

core/src/core.cpp Outdated Show resolved Hide resolved
Oyaki122 and others added 2 commits December 8, 2021 13:43
Co-authored-by: Yosshi999 <Yosshi999@users.noreply.github.com>
Copy link
Contributor

@Yosshi999 Yosshi999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 2b159eb into VOICEVOX:main Dec 8, 2021
@Oyaki122 Oyaki122 deleted the yukarin_s_delta_length branch December 8, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yukarin_sの結果が正の値でない場合は微小値を返す
3 participants